Fix bug where a buffer construction is attempted in env without it#209
Merged
Conversation
like a web browser that didn't have a system to polyfill buffer in when encountered during bundling.
also add integration tests to CI (this is likely to need some iteration)
so they work in CI where CPU is way more variable. Required adding some things to wait for in cases that didn't already create an element at the right time in the process.
giarc3
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
like a web browser that didn't have a system to polyfill buffer in when encountered during bundling.
I ran this new integration test against staging where it fails with the expected error about Buffer not existing (the one I ran into when doing an example Todo app). It also succeeds locally against the dev cluster + integration server proxying the fixed frame.
The fix is in
src/frame/protobuf/index.ts, everything else is getting the integration tests running currently, trying to capture how I ran them.There's also a fix in
src/frame/index.tsfor streaming blocking on its initial write of IV/Header.integration/README.mdcovers how running integration tests works now. They generate localhost self-signed certs automatically (so no more re-downloading and extracting dev certs every time you come back to this repo), and a canned assertion key and project for staging are encrypted inintegration/projects. The tests run against staging for auth/assertion/project+segment, but through a proxy that replaces the frame/worker with the local ones. So by default you're testing all your local code but without needing to run the IC-ID stack or set up an admin project.You still can run the local stack, set up a project, or run the tests against specific version frames in stage/prod if you want, but the default is now the easy and fully canned pattern.